Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup security secure-machines page #663

Merged

Conversation

kprosise
Copy link
Contributor

Focus was on style and readability.
This page currently has issues with content, such as those discussed in FFTK-2841, which will require greater rework, and will be addressed separately from the cleanup effort.

QA Steps: Ran linter, spellcheck, and checked rendered html.

This commit applies to FFTK-2795

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

unsure about some changes made, feel free to question.

@doanac
Copy link
Member

doanac commented Jan 17, 2024

Focus was on style and readability.
This page currently has issues with content, such as those discussed in
FFTK-2841, which will require greater rework, and will be addressed
separately from the cleanup effort.

QA Steps: Ran linter, spellcheck, and checked rendered html.

This commit applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise force-pushed the cleanup-security-secure-aspects-machines branch from 80c9948 to f8be591 Compare January 18, 2024 12:50
@doanac
Copy link
Member

doanac commented Jan 18, 2024

@kprosise kprosise merged commit 4a5dfc4 into foundriesio:main Jan 23, 2024
2 of 3 checks passed
@kprosise kprosise deleted the cleanup-security-secure-aspects-machines branch January 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants