Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for aktualizr-lite update #660

Merged

Conversation

kprosise
Copy link
Contributor

Brief warning added as single line.

QA steps: viewed rendered html.

This commit addresses FFTK-2965

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@doanac
Copy link
Member

doanac commented Jan 14, 2024

Brief warning added, as well as a simple explanation as to why
downgrading is not supported/recommended by support.

QA steps: viewed rendered html.

This commit addresses FFTK-2965

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise force-pushed the add-aktualizr-lite-rollback-admonition branch from 1bf9499 to abf0250 Compare January 16, 2024 11:25
@doanac
Copy link
Member

doanac commented Jan 16, 2024

@kprosise kprosise merged commit 1432c9d into foundriesio:main Jan 17, 2024
2 of 3 checks passed
@kprosise kprosise deleted the add-aktualizr-lite-rollback-admonition branch January 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants