Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup secure-boot imx security rm pages #653

Merged

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Jan 9, 2024

Minor changes for readability and style made to the two pages.

QA Steps: checked rendered output, no issues noticed. Ran linter.

This commit applies to FFTK-2795

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Minor changes for readability and style made to the two pages.

QA Steps: checked rendered output, no issues noticed. Ran linter.

This commit applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise force-pushed the cleanup-security-secure-boot-imx branch from 63fd82c to 6f60a3f Compare January 10, 2024 10:58
@doanac
Copy link
Member

doanac commented Jan 10, 2024

@kprosise kprosise merged commit d804cef into foundriesio:main Jan 11, 2024
1 of 3 checks passed
@kprosise kprosise deleted the cleanup-security-secure-boot-imx branch January 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants