Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup factory-registration security rm page #649

Merged

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Jan 8, 2024

Style and readability fixes applied.

The subsections had duplicate naming which I attempted to address accurately.

Viewed rendered output. Ran linter.

This commit applies to FFTK-2795

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Section headers/titles should be checked for accuracy.

@doanac
Copy link
Member

doanac commented Jan 8, 2024

@doanac
Copy link
Member

doanac commented Jan 9, 2024

Style and readability fixes applied.

The subsections had duplicate naming which I attempted to address
accurately.

Viewed rendered output. Ran linter.

This commit applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise force-pushed the cleanup-security-device-registration branch from 96d5453 to 3583a01 Compare January 9, 2024 10:23
@doanac
Copy link
Member

doanac commented Jan 9, 2024

@kprosise kprosise merged commit 424f2c8 into foundriesio:main Jan 9, 2024
2 of 3 checks passed
@kprosise kprosise deleted the cleanup-security-device-registration branch January 9, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants