-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: linux: add linux-nfs-boot information #646
Conversation
Succintly document how to NFS mount a WIC image that uses OStree. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Docs for bd091f1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2540/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the suggestions are minor markdown formatting or related to style.
Co-authored-by: Katrina Prosise <[email protected]>
Docs for 6f9a459 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2541/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Generally, NFS booting any LmP system requires configuring NFS support | ||
in the ramdisk, along with a TFTP server and an NFS server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be the first sentence in this intruduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right!
Yocto enables modular initramfs configuration, allowing selective | ||
support for udev, rootfs, ostree, or network filesystem in the | ||
ramdisk. Adding NFS and OSTree ramdisk support permits switch root | ||
scripts to prepare shared network filesystem for mounting on the target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand the goal of this sentence.
Would this order be ok?
Yocto enables modular initramfs configuration, allowing selective | |
support for udev, rootfs, ostree, or network filesystem in the | |
ramdisk. Adding NFS and OSTree ramdisk support permits switch root | |
scripts to prepare shared network filesystem for mounting on the target. | |
Adding NFS and OSTree ramdisk support permits switch root | |
scripts to prepare shared network filesystem for mounting on the target | |
because there are modular initramfs configuration, allowing selective | |
support for udev, rootfs, ostree, or network filesystem in the | |
ramdisk. |
Why is it important to mention that "Adding NFS and OSTree ramdisk support permits switch root
scripts to prepare shared network filesystem for mounting on the target."? It looks loose to me...
But if you want to mention this, use The Yocto Project instead of yocto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it wss important to mention just because I didnt know about it :) but it could very well be that is common knowledge and it is just me that wasnt aware of it...but yeah, I'd rather keep it.
Enabling NFS Support on initramfs | ||
--------------------------------- | ||
|
||
To configure the ramdisk for NFS boot using Yocto requires enabling the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To configure the ramdisk for NFS boot using Yocto requires enabling the | |
To configure the ramdisk for NFS boot using LmP requires enabling the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lmp uses Yocto and Yocto uses the module. I'd rather point to the last element in the chain (ie Yocto)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, use "the Yocto Project" instead of only yocto
|
||
.. prompt:: text | ||
|
||
diff --git a/meta-lmp-base/recipes-core/images/initramfs-ostree-lmp-image.bb b/meta-lmp-base/recipes-core/images/initramfs-ostree-lmp-image.bb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not supposed to be built on a factory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, but it is not enabled by default so someone will have to take action in their override...should I provide a meta-subscriber-override patch instead? I always build locally on my box hence why I didnt bother with the override and just used the patch that @rsalveti shared with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point here is what is needed to make the NFS work is only available via local build?
One argument to keep the local build only is to make sure people will not start using NFS for things other than testing/dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should cover both cases.I'll add the subscribers patch as well. @angolini I think a more generic - less restrictive - doc is a better doc. What do you think?
Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Docs for a675add are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2544/docs/artifacts/html/index.html |
@ldts I can go ahead and merge whenever you're ready |
from my side it looks good - I tested on Zynqmp but being these a set of guidelines more than anything else, it should suffice. |
Succintly document how to NFS mount a WIC image that uses OStree.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.