Add functionality for multiple repos - fix for 8.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guffelman
changed the title
|
I haven't tried running this yet, but I suspect install.sh also wants a change to enable a new /etc/apt/sources.list.d/ceph-no-subscription.list similar to how it creates the pve-no-subscription.list file. I don't understand why the repo is split up into two files install.sh and the embedded base64 version of pve-nag-buster.sh, the latter of which deletes the enterprise file and the former creating the new file, but in this case it hides the fact that the pull request isn't quite complete as far as PVE8 goes. |
Yrlish
reviewed
Feb 6, 2024
| @@ -10,7 +10,7 @@ means. High quality open source software like Proxmox needs our support! | |||
|
|
|||
| ### News: | |||
|
|
|||
| Last updated for: pve-manager/6.4-4/337d6701 (running kernel: 5.4.106-1-pve) | |||
| Last updated for: pve-manager/8.0.4/d258a813cfa6b390 (running kernel: 8.0.4) | |||
There was a problem hiding this comment.
There is no kernel 8.x yet. It's proxmox version 8 but kernel 6.5
|
I just forked the repo and added your changes to it. It works, I just ran it myself on a freshly installed PVE 8.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new function disable_repo() that allows you to pass a repository in to disable. It will change the repository to "$REPO_BASE.disabled"
This should allow for multiple repositories to be disabled, which fixes the release for 8.0. They added a new enterprise repo in ceph.list.
Thanks!
G