Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PBS and PMG #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yukigamine
Copy link

Add scripts for pmg and pbs

Disable paid repo first because UI can lock up/cancel remaining commands when restarted.

Adjust install.sh to check for Proxmox services on the box and install the appropriate script

Fixes #6

Disable paid repo first because UI can lock up/cancel
remaining commands when restarted.

Adjust install.sh to check for Proxmox services on the box and
install the appropriate script
@Yukigamine
Copy link
Author

The PMG functionality needs testing as I don't have a server. Can test the new scripts using --offline or cloning the repo down so it doesn't look at github.

@ragecc
Copy link

ragecc commented Feb 16, 2023

I just found this repo tonight while deciding to start working on my new proxmox host. I noticed back in May of 21 is the latest master. I checked the issues and found some lines that can be changed and this (which you submitted around 9 hr ago oddly enough). Im just wondering who to ask or what to use? I'm running pve 7.3-1 and it shows running pve-manager 7.3-3. Should I wait for this pr to be merged to main or get it from the repo its submitted from or what. Thank you, Chad

@Yukigamine
Copy link
Author

I'm not sure what issues they were having in #9 as the current lines using sed are still working for me on pve-manager 7.3-3, but I know @foundObjects was trying to move away from sed in #5 which I think is part of what was got changed in @ngadmini's version.

I didn't really feel like trying to figure that out since the sed version was still working for me.
I'd say you can give either one a shot, but this PR was specifically to add support for PBS and PMG in addition to PVE.

@ragecc
Copy link

ragecc commented Feb 16, 2023

I'm not sure what issues they were having in #9 as the current lines using sed are still working for me on pve-manager 7.3-3, but I know @foundObjects was trying to move away from sed in #5 which I think is part of what was got changed in @ngadmini's version.

I didn't really feel like trying to figure that out since the sed version was still working for me. I'd say you can give either one a shot, but this PR was specifically to add support for PBS and PMG in addition to PVE.

Hey! Thanks for the reply! I could just uninstall either one I try or even try both as long as I uninstall the first before trying the second and then the second if I preferred the first version correct? Is @ngadmini the person that's in charge or a contributer or? Can you throw me a link to the most current version beside yours? I'm not sure which since updates seem to be in issues and stay there. Luckily I'm curious or I would had thought the project was abandoned from the main page of the repo. Thanks again!

@Yukigamine
Copy link
Author

@foundObjects is the owner of the repo and project and @ngadmini is the one who wrote those different lines of code you saw.

I can look into integrating those into this PR later, just probably not today.

If you're just working with PVE, you can either use:

@ragecc
Copy link

ragecc commented Feb 16, 2023

I can wait. If I was more familiar with evrybody and what all is going on I would offer help even. I'm just moving and upgrading my homelab to a new server. For a couple years I had been using ubuntu server with docker and portainer on my server. I got a new server and decided to move to proxmox and start with a vm or a container (not sure which would be best yet) with ubuntu server running docker and portainer like before. I have so many different projects going on, but I decided yesterday to finally focus on this until its at least running everything I had on the old server. I know quite a bit of stuff, but proxmox is new to me. I don't think my second drive is showing up. I still have to figure our what kind of volume to mount it as, proxmox is on the nvme ssd, and its split from what I can tell. After that I'll have to figure out if I should leave that alone and just have the 2nd hard drive as backup and images or move the spit part to the other and figure out how to allocate that space back to the part proxmox is running on. I think figure out vm or container to run ubuntu server and spin it up is all. After that I'll be back to familiar territory.

@ngadmini
Copy link

* https://gist.github.com/ngadmini/7f9df377999cc78c1b58e361d5425ac4 - made by @ngadmini and linked in [[Proxmox VE]  pve-manager 7.2-11/b76d3178 with proxmox-widget-toolkit 3.5.1 #9](https://github.com/foundObjects/pve-nag-buster/issues/9) as a newer way to remove nag messages

Just make sure to use the latest version, due to frequently update

@ragecc
Copy link

ragecc commented Feb 20, 2023

* https://gist.github.com/ngadmini/7f9df377999cc78c1b58e361d5425ac4 - made by @ngadmini and linked in [[Proxmox VE]  pve-manager 7.2-11/b76d3178 with proxmox-widget-toolkit 3.5.1 #9](https://github.com/foundObjects/pve-nag-buster/issues/9) as a newer way to remove nag messages

Just make sure to use the latest version, due to frequently update

Right now I turned off the enterprise updates and turned on the non enterprise (Forget the name and not around to look ATM) Im confused on where to look for the latest. I assume the link in your reply is right now. If I make sure PVE is running the latest version right now point me to what I need and I'll do it. Thanks yall for your help.

@ngadmini
Copy link

ngadmini commented Feb 21, 2023

... I assume the link in your reply is right now. ...

yes, that what i mean

... If I make sure PVE is running the latest version right now point me to what I need and
I'll do it. Thanks yall for your help.

please see this comment

@dooferorg
Copy link

I have a proxmox mail gateway and soon a backup server as well. Great that you got it working. I will get this downloaded and test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize to support Proxmox VE, Mail Gateway and Backup Server
4 participants