feat: Implement recaptcha verification during signup #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +42,7 @@ class SignUpActivity : AppCompatActivity(), ISignUpView { | |||
| private lateinit var forgotPasswordProgressDialog: Dialog | |||
| private lateinit var builder: AlertDialog.Builder | |||
| private var checkDialog: Boolean = false | |||
| private val RECAPTCHA_KEY = "6LcKhbMUAAAAAGFbYZeNFzqol-7EjOHUK5MvEeOE" | |||
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 9c4f090. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 1048cc2. Here's the output:
|
|
@iamareebjamal please add the API key. The build is failing because it's not getting the key. |
mariobehling
requested changes
Aug 29, 2019
|
Build should not fail if there is no API key The feature should only enable in presence of the API key |
|
I will update it accordingly. |
akshatnitd
reviewed
Sep 1, 2019
| SafetyNet.getClient(this).verifyWithRecaptcha(RECAPTCHA_KEY) | ||
| .addOnSuccessListener(this, OnSuccessListener { response -> | ||
| val userResponseToken = response.tokenResult | ||
| Log.d("KHANKI", "Started recaptcha verification") |
| val stringPassword = password.editText?.text.toString() | ||
| val stringConfirmPassword = confirmPassword.editText?.text.toString() | ||
| val stringURL = inputUrlSignUp.editText?.text.toString() | ||
| Log.d("KHANKI", "Signned up") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2350
Changes:
Screenshots for the change:
