Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dashboard and Left section #3653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Devesh21700Kumar
Copy link

Fixes #3652 #3627
Changes: [Add here what changes were made in this pull request and if possible provide links showcasing the changes.]

1). Used MUI styling for some components
2). Fixed scroll and set the position as fixed of the left section/sidebar
3). Ensured responsiveness on screen sizes and different interfaces
4). Fixed all overflows that occurred due to margins
5). No linting errors present

Commands used:-
1). yarn start to run the web app on localhost
2). yarn run lint --fix to fix linting errors

Screenshots of the change:

image

image

@isuruAb
Copy link
Member

isuruAb commented Oct 18, 2021

Please don't change the indentation of the code in the same PR. Because it makes the reviewer's job difficult.

@Devesh21700Kumar
Copy link
Author

Please don't change the indentation of the code in the same PR. Because it makes the reviewer's job difficult.

I think that the indentation changed because of adding new elements to wrap some components. Running yarn run lint —fix in the end might have caused this.

Copy link
Member

@isuruAb isuruAb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Author

@Devesh21700Kumar Devesh21700Kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruAb @Orbiter Pls do merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create button overflow
2 participants