Update utils.py #72
Open
Update utils.py #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebrabbani
requested changes
Oct 13, 2021
| return int(strVal, 16) if type(strVal) == str and strVal.startswith('0x') else int(strVal, 10) | ||
| def hex_to_int(value: str) -> int: | ||
| if not (isinstance(value, str) and len(value) > 0): | ||
| raise TypeError('The value must not be an empty str!') |
There was a problem hiding this comment.
we still want to allow None as a valid input (this would happen when creating a test block_event or transaction_event without having to specify every field)
| assert_key_in_dict(dict, key) | ||
| assert isinstance(dict[key], enum), f'{key} must be valid enum value' | ||
| @is_valid_key | ||
| def is_valid_string(dict: dict, key: int or str): |
There was a problem hiding this comment.
lets keep the function names the same (i.e. assert_enum_value_in_dict and assert_non_empty_string_in_dict) as they are used in other places as well
| dict[key]) > 0, f'{key} must be non-empty string' | ||
| def is_valid_key(func: callable): | ||
|
|
||
| def wrap(dict: dict, key: str or int, *args, **kwargs): |
There was a problem hiding this comment.
the key type should always be str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.