Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable admin profiler #1323

Closed
wants to merge 1 commit into from

Conversation

reclaro
Copy link
Contributor

@reclaro reclaro commented Nov 26, 2018

This change adds a way to disable the admin profiler when the admin
server is enabled.

I added a new env variable that can be used to disable the admin profiler
To verify it you can:

  • Enable the admin api
  • set the "FN_ENABLE_ADMIN_PROFILER" to "false"
  • GET the admin_api:admin_port/debug/vars, you should get an error

This change adds a way to disable the admin profiler when the admin
server is enabled.
Copy link
Contributor

@rdallman rdallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a really weird concern? are there issues with having admin authentication guarding these endpoints to begin with? - that seems like the real issue, no admin should reasonably be worried about this?

@reclaro
Copy link
Contributor Author

reclaro commented Nov 27, 2018

Hey @rdallman thanks for your comment, this is not a big deal i am happy to abandon this change if we think there is no value, the reason because I am proposing this is that we can have some FN implementations where different profiling mechanism are plugged into the system and therefore the net/http/pprof won't be necessary and ppl want a way to switch it off.

@reclaro
Copy link
Contributor Author

reclaro commented Nov 27, 2018

working on this thing I noticed that we don't call the wrapper for injecting middleware in the Admin API, I opened a PR for this #1327

@rdallman
Copy link
Contributor

@reclaro i think that #1327 is the right path forward here, thanks for following up

@reclaro
Copy link
Contributor Author

reclaro commented Nov 28, 2018

Ok I close this ticket in favor of #1327

@reclaro reclaro closed this Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants