-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update for image spec/fast register notes #5726
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
==========================================
- Coverage 36.21% 36.20% -0.01%
==========================================
Files 1303 1303
Lines 109560 109560
==========================================
- Hits 39675 39669 -6
- Misses 65765 65771 +6
Partials 4120 4120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@neverett could you take a look at this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions for clarity, but overall LGTM.
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]>
Why are the changes needed?
Update to docs to clarify pyflyte command args and the relationship between fast register and imagespec.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Related to flyteorg/flytekit#2731
Docs link