Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] add an error in base case for file size exceeded #5725

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wild-endeavor
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 36.20%. Comparing base (a058fd1) to head (20bb8cb).

Files with missing lines Patch % Lines
...lytepropeller/pkg/controller/nodes/task/handler.go 0.00% 8 Missing ⚠️
...uginmachinery/ioutils/remote_file_output_reader.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5725      +/-   ##
==========================================
- Coverage   36.21%   36.20%   -0.01%     
==========================================
  Files        1303     1303              
  Lines      109560   109568       +8     
==========================================
- Hits        39675    39669       -6     
- Misses      65765    65779      +14     
  Partials     4120     4120              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.17% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <0.00%> (ø)
unittests-flytepropeller 41.74% <0.00%> (-0.02%) ⬇️
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant