Page size 3value fix #383
Merged
Page size 3value fix #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on latest version - works |
asolntsev
requested changes
Sep 12, 2024
| @@ -94,7 +94,7 @@ public List<PropertyDeclaration> buildDeclarations( | |||
| } else { | |||
| throw new CSSParseException("Value for " + cssName + " must be a length or identifier", -1); | |||
| } | |||
| } else { /* values.size == 2 */ | |||
| } else if (values.size() == 2) { /* values.size == 2 */ | |||
There was a problem hiding this comment.
Is this comment is still needed?
It just duplicates the code.
There was a problem hiding this comment.
cleaned, sorry (modification made in plaintext editor)
| @@ -147,6 +147,35 @@ public List<PropertyDeclaration> buildDeclarations( | |||
| } else { | |||
| throw new CSSParseException("Invalid value for size property", -1); | |||
| } | |||
| } else if (values.size() == 3) { | |||
| PropertyValue value1 = (PropertyValue) values.get(0); | |||
There was a problem hiding this comment.
Can't we have at least some tests for this code?
It should be easy:
class SizePropertyBuilderTest {
private final SizePropertyBuilder builder = new SizePropertyBuilder();
@Test
void buildDeclarations() {
PropertyValue cssValue = new PropertyValue(CSS_NUMBER, 2.0f, "foo");
List<PropertyDeclaration> result = builder.buildDeclarations(COUNTER_INCREMENT, List.of(cssValue), 42, false);
assertThat(result).hasSize(1);
assertThat(result).containsExactly(new PropertyDeclaration(COUNTER_INCREMENT, cssValue, false, 42));
}
}There was a problem hiding this comment.
I'll try to prepare that, I'm a bit struggling with building the lib in Eclipse...
jelinj8
force-pushed
the
page_size_3value_fix
branch
from
036ea95
to
652f49d
Compare
asolntsev
added a commit
that referenced
this pull request
Sep 16, 2024
|
@jelinj8 Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create a PDF for a label printer with landscape orientation AND a custom size which evidently isn't supported.
This is an attempt to fix that (+ fixed one typo in original code reporting error on incorrect parameter value).
I'm unable to test this properly right now with current version as I'm unable to compile the library with Java 17 (still using FS 9.4.1 with Java 1.8), but it compiled OK and works (with slight modifications for the old version), this is to get it fixed when I'll be able to upgrade and to give something back, thanks.
Succesfully created portrait label on landscape paper 40x20mm...