-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caliper Integration #39
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sublibraries provide a common interface to sending/receiving data using different tools. The tools currently supported in the DTL sublibraries are: * Flux RPC (i.e., how DYAD has previously moved data) * UCX To control which tool is used, users can set the DYAD_DTL_MODE environment variable for the APIs. For the module/service, users specify which tool to use by passing a second argument on the command line. For both APIs and the module/service, the default DTL mode is Flux RPC.
This PR is based on #24. |
ilumsden
force-pushed
the
caliper-integration
branch
from
July 28, 2023 19:44
b1a1394
to
409d69a
Compare
The specific changes made in this commit are: 1. Ensures extern C is added everywhere it is needed 2. Adds update to CXXFLAGS to configure.ac 3. Removes sync_started 4. Moves dyad_kvs_response_t to dyad_core.c 5. Moves method assignment for dyad_dtl_t to underlying DTL implementations 6. Adds END variants to enums in DTL 7. Adds restrict everywhere I can
…codes for DYAD based on DTL
ilumsden
force-pushed
the
caliper-integration
branch
from
July 31, 2023 17:25
5da02de
to
f452dbb
Compare
Closing this PR in favor of a newer and better implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds annotations and support for Caliper to DYAD.
This is still WIP because I need to add code to
configure.ac
to locate Caliper.Once that code is added, users can enable Caliper annotations at build time by adding
--enable-caliper
to the invocation of theconfigure
script.At runtime, users can enable Caliper using the
CALI_CONFIG
environment variable (as is standard for Caliper).