Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caliper Integration #39

Closed
wants to merge 18 commits into from

Conversation

ilumsden
Copy link
Collaborator

This PR adds annotations and support for Caliper to DYAD.

This is still WIP because I need to add code to configure.ac to locate Caliper.

Once that code is added, users can enable Caliper annotations at build time by adding --enable-caliper to the invocation of the configure script.

At runtime, users can enable Caliper using the CALI_CONFIG environment variable (as is standard for Caliper).

These sublibraries provide a common interface to sending/receiving
data using different tools. The tools currently supported in the DTL
sublibraries are:
* Flux RPC (i.e., how DYAD has previously moved data)
* UCX

To control which tool is used, users can set the DYAD_DTL_MODE
environment variable for the APIs. For the module/service, users
specify which tool to use by passing a second argument on the
command line. For both APIs and the module/service, the default
DTL mode is Flux RPC.
@ilumsden ilumsden added the enhancement New feature or request label Jul 28, 2023
@ilumsden ilumsden self-assigned this Jul 28, 2023
@ilumsden
Copy link
Collaborator Author

This PR is based on #24.

The specific changes made in this commit are:

1. Ensures extern C is added everywhere it is needed
2. Adds update to CXXFLAGS to configure.ac
3. Removes sync_started
4. Moves dyad_kvs_response_t to dyad_core.c
5. Moves method assignment for dyad_dtl_t to underlying DTL implementations
6. Adds END variants to enums in DTL
7. Adds restrict everywhere I can
@ilumsden
Copy link
Collaborator Author

ilumsden commented Oct 5, 2023

Closing this PR in favor of a newer and better implementation

@ilumsden ilumsden closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant