Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Evict the captured image cache once returned from the viewer #244

Merged
merged 3 commits into from
Oct 4, 2024
Merged

⚡️ Evict the captured image cache once returned from the viewer #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a57808f
⚡️ Evict the captured image cache once returned from the viewer
AlexV525 Apr 28, 2024
416b366
📝 CHAGELOG
AlexV525 May 10, 2024
ad11fa1
Merge branch 'main' into fix/evict-precached-image
AlexV525 Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ See the [Migration Guide](guides/migration_guide.md) for breaking changes betwee

## Unreleased

*None.*
- Evict the captured image cache once returned from the viewer.

## 4.3.2

Expand Down
11 changes: 10 additions & 1 deletion lib/src/states/camera_picker_state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,15 +1087,24 @@ class CameraPickerState extends State<CameraPicker>
required XFile file,
required CameraPickerViewType viewType,
}) async {
final FileImage? image;
if (viewType == CameraPickerViewType.image) {
image = FileImage(File(file.path));
await precacheImage(FileImage(File(file.path)), context);
} else {
image = null;
}
return CameraPickerViewer.pushToViewer(
final result = await CameraPickerViewer.pushToViewer(
context,
pickerConfig: pickerConfig,
viewType: viewType,
previewXFile: file,
);
if (image != null) {
final evicted = PaintingBinding.instance.imageCache.evict(image);
realDebugPrint('Preview image cache evicted: $evicted');
}
return result;
}

////////////////////////////////////////////////////////////////////////////
Expand Down
Loading