Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use before/afterPaintImage callbacks in editing too #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolocomotive
Copy link

For some reason these seem to be disable whe the edit mode is enabled. I couldn't find any mention of this anywhere so I assume this is a bug/not intentional behaviour. Seems to work fine.

@zmtzawqlp
Copy link
Member

zmtzawqlp commented Mar 15, 2024

What are your requirements about it? Can you illustrate with a scenario?

@lolocomotive
Copy link
Author

I use this to draw a checkerboard background behind the image to show transparency. It works just fine when the mode is none or gesture, but as soon as the mode is edit, the callbacks are ignored. Adding the 2 lines of code seems to add the functionality back without any side effects although I haven't tested thouroughly.

@zmtzawqlp zmtzawqlp self-requested a review as a code owner September 10, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants