Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sumo option of traffic scale in visualizing #898

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add sumo option of traffic scale in visualizing #898

wants to merge 4 commits into from

Conversation

pengyuan-zhou
Copy link
Contributor

as the title

@pengyuan-zhou pengyuan-zhou changed the title add traffic scale option to running with sumo add sumo option, scale, in params Apr 5, 2020
@pengyuan-zhou pengyuan-zhou changed the title add sumo option, scale, in params add sumo option of traffic scale in visualizing Apr 5, 2020
@coveralls
Copy link

coveralls commented Apr 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5617

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 89.554%
Totals Coverage Status
Change from base Build 5516: 0.004%
Covered Lines: 9336
Relevant Lines: 10425
💛 - Coveralls

eugenevinitsky
eugenevinitsky reviewed Apr 5, 2020
View reviewed changes
flow/core/params.py
@@ -395,6 +395,7 @@ class SimParams(object):

def __init__(self,
sim_step=0.1,
scale=1.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you add an explanation of what this does to the docstring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, done :)

eugenevinitsky
eugenevinitsky reviewed Apr 5, 2020
View reviewed changes
flow/core/params.py
@@ -573,6 +575,7 @@ class SumoParams(SimParams):
def __init__(self,
port=None,
sim_step=0.1,
scale=1.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done:)

@pengyuan-zhou
Copy link
Contributor Author

@eugenevinitsky Hi, is there any issue with this snippet?

eugenevinitsky
eugenevinitsky approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

eugenevinitsky
eugenevinitsky requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is scale actually passed to SUMO?

@pengyuan-zhou
Copy link
Contributor Author

Where is scale actually passed to SUMO?

Hi, it's been a while and I can't recall. But it's an official option of sumo as shown here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugenevinitsky eugenevinitsky eugenevinitsky requested changes

@AboudyKreidieh AboudyKreidieh Awaiting requested review from AboudyKreidieh AboudyKreidieh is a code owner

@cathywu cathywu Awaiting requested review from cathywu

@kanaadp kanaadp Awaiting requested review from kanaadp

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pengyuan-zhou @coveralls @eugenevinitsky