Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wave_attenuation.py #897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SHITIANYU-hue
Copy link

The previous code can only display one rl vehicle, this way it can display all rl vehicles and their leader and follower vehicles, which is in accordance to the paper.

Pull request information

  • Status: ? (ready to merge / in development)
  • Kind of changes: ? (bug fix / new feature / documentation...)
  • Related PR or issue: ? (optional)

Description

? (general description)

The previous code can only display one rl vehicle, this way it can display all rl vehicles and their leader and follower vehicles, which is in accordance to the paper.
@eugenevinitsky
Copy link
Member

Hi, can you make sure this passes the test pydocstyle --convention numpy before we review this? Thanks for the PR!

@SHITIANYU-hue
Copy link
Author

Sorry, i am not quite familiar with:pydocstyle --convention numpy, but i am sure this can run successfully.

@eugenevinitsky
Copy link
Member

eugenevinitsky commented Apr 5, 2020

Hi, so we use pydoc to enforce rules on our documentation. You can run it locally by doing:
pip install pydocstyle
pydocstyle --convention numpy
and then fixing the lines it complains about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants