Optimize score list views #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florczakraf
force-pushed
the
optimize-scores-view
branch
from
1cf65ce
to
3789d7e
Compare
KyRZy
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though there are proper indices in the db, some of the queries are going to be slow when we have to scan and discard a lot of rows. This is the case when we try to access high page numbers of score and highscore lists. The latter is even more problematic, because it orders the rows by two indices.
This PR is not a solution but somewhat a WA for the time being. We will have to think of reworking the scores list, for example by limiting public views to the last month of scores or some N scores to prevent web scrapers and indexing bots from draining the server resources.
before:
after:
