Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit #191

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Add pre-commit #191

merged 7 commits into from
Aug 8, 2024

Conversation

florczakraf
Copy link
Owner

Summary

  • we're now using a standard pre-commit tool to perform all the required code style checks
  • added isort (it enforces consistent import order)
  • updated CI to use pre-commit
  • updated dev docs to suggest using pre-commit instead of all the required tools manually
  • resolved all issues (mostly missing LF, removed unneeded executable flags, import order -- separate commit with isort)

@florczakraf florczakraf self-assigned this Aug 3, 2024
@florczakraf florczakraf added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 3, 2024
This avoids excluding .github/ directory that contains CI pipeline
configuration.
@florczakraf florczakraf merged commit fc08e0d into master Aug 8, 2024
11 checks passed
@florczakraf florczakraf deleted the add-precommit branch August 8, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants