vulkan: Fix present mode fallback override #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In overlay_CreateSwapchainKHR, if IsPresentModeSupported returns false (which it will when FIFO_RELAXED is not supported) it sets HUDElements.cur_present_mode to VK_PRESENT_MODE_FIFO_KHR but it does not update createInfo.presentMode. This can cause swapchain creation to fail since it's trying to use an unsupported present mode. This updates the createInfo's presentMode as well to prevent this.
|
This looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen some reports of blank screens on games with Xwayland when vsync is disabled in MangoHud:
https://forums.developer.nvidia.com/t/blank-screens-on-games-with-adaptive-vsync-fifo-relaxed-khr-enabled-driver-550-regression-works-on-535/284442
It doesn't look like MangoHud correctly handles
FIFO_RELAXED_KHRnot being supported. Inoverlay_CreateSwapchainKHR, ifIsPresentModeSupportedreturns false (which it will forFIFO_RELAXEDon our driver with Xwayland at the moment) it setsHUDElements.cur_present_modetoVK_PRESENT_MODE_FIFO_KHRbut it does not updatecreateInfo.presentMode. This could cause swapchain creation to fail since it's trying to use an unsupported present mode.Does this analysis sound correct or am I misunderstanding how this should work?
Some additional context: earlier this summer we had stopped advertising
FIFO_RELAXED_KHRwith Xwayland in the NVIDIA driver since we weren't properly handling it and were treating it as regular FIFO, which was a bug. That seems to have triggered this issue. We will be implementingFIFO_RELAXED_KHRproperly as we do want to support it on Xwayland, but figured I would report this issue in the meantime.