Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface for differentiating inputs and weights in CG & PCG #1493

Merged
merged 6 commits into from
Sep 16, 2024

Address Reyna PR comments

b8d5ec3
Select commit
Loading
Failed to load commit list.
Merged

Add interface for differentiating inputs and weights in CG & PCG #1493

Address Reyna PR comments
b8d5ec3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 15, 2024 in 1s

90.45% of diff hit (target 68.49%)

View this Pull Request on Codecov

90.45% of diff hit (target 68.49%)

Annotations

Check warning on line 54 in lib/local-execution/src/local_cost_estimator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/local-execution/src/local_cost_estimator.cc#L54 

Added line #L54 was not covered by tests

Check warning on line 74 in lib/local-execution/src/local_cost_estimator.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/local-execution/src/local_cost_estimator.cc#L72-L74 

Added lines #L72 - L74 were not covered by tests

Check warning on line 15 in lib/op-attrs/src/op-attrs/computation_graph_op_attrs.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/computation_graph_op_attrs.cc#L13-L15 

Added lines #L13 - L15 were not covered by tests

Check warning on line 27 in lib/op-attrs/src/op-attrs/computation_graph_op_attrs.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/computation_graph_op_attrs.cc#L21-L27 

Added lines #L21 - L27 were not covered by tests

Check warning on line 26 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L25-L26 

Added lines #L25 - L26 were not covered by tests

Check warning on line 57 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L55-L57 

Added lines #L55 - L57 were not covered by tests

Check warning on line 71 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L69-L71 

Added lines #L69 - L71 were not covered by tests

Check warning on line 74 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L73-L74 

Added lines #L73 - L74 were not covered by tests

Check warning on line 86 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L85-L86 

Added lines #L85 - L86 were not covered by tests

Check warning on line 89 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L88-L89 

Added lines #L88 - L89 were not covered by tests

Check warning on line 91 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L91 

Added line #L91 was not covered by tests

Check warning on line 97 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L95-L97 

Added lines #L95 - L97 were not covered by tests

Check warning on line 99 in lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/get_incoming_tensor_roles.cc#L99 

Added line #L99 was not covered by tests

Check warning on line 111 in lib/op-attrs/src/op-attrs/ops/attention.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/ops/attention.cc#L111 

Added line #L111 was not covered by tests

Check warning on line 20 in lib/op-attrs/src/op-attrs/ops/conv_2d.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/ops/conv_2d.cc#L20 

Added line #L20 was not covered by tests

Check warning on line 24 in lib/op-attrs/src/op-attrs/ops/layer_norm.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/ops/layer_norm.cc#L24 

Added line #L24 was not covered by tests

Check warning on line 23 in lib/op-attrs/src/op-attrs/ops/linear.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/ops/linear.cc#L23 

Added line #L23 was not covered by tests

Check warning on line 6 in lib/op-attrs/src/op-attrs/ops/topk.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/op-attrs/src/op-attrs/ops/topk.cc#L5-L6 

Added lines #L5 - L6 were not covered by tests

Check warning on line 92 in lib/pcg/src/pcg/computation_graph.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph.cc#L92 

Added line #L92 was not covered by tests

Check warning on line 101 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L100-L101 

Added lines #L100 - L101 were not covered by tests

Check warning on line 104 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L104 

Added line #L104 was not covered by tests

Check warning on line 470 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L470 

Added line #L470 was not covered by tests

Check warning on line 473 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L472-L473 

Added lines #L472 - L473 were not covered by tests

Check warning on line 499 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L497-L499 

Added lines #L497 - L499 were not covered by tests

Check warning on line 514 in lib/pcg/src/pcg/computation_graph_builder.cc

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/pcg/src/pcg/computation_graph_builder.cc#L513-L514 

Added lines #L513 - L514 were not covered by tests
View more details on Codecov