Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Fix observer persisting host_id when querying host from host details page #22249

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

RachelElysia
Copy link
Member

Issue

Cerra #20959

Description

  • Bug: Design decision to not allow observers to access edit query page and redirect to query details page caused regression with allowing observers to flow host_id into query flow that starts on edit query page from host details page > query option
  • Fix: Since observers are pushed to the query details page when they don't have access to edit query page, persist host_id param on query details page as well, so when user goes to live query flow, the host_id param persists

Screen recording of fix

https://www.loom.com/share/6fdf3682bf46424b8d26eae33e78f326?sid=c167192e-0edc-476e-8023-f41f630764b5

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (90c04ee) to head (88e1510).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
frontend/router/paths.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22249      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      117110   117111       +1     
  Branches     3512     3512              
==========================================
  Hits        76365    76365              
- Misses      33627    33628       +1     
  Partials     7118     7118              
Flag Coverage Δ
frontend 52.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 2708988 into main Sep 20, 2024
14 checks passed
@RachelElysia RachelElysia deleted the observer-query-host-flow-fix branch September 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants