Dogfood: remove "Explore data (fleetdm.com)" team #22246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtalerman
requested review from
lukeheath,
spokanemac and
getvictor
as code owners
noahtalerman
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Hey @lukeheath, when you get the chance can you please help remove this variable from the repo? (cleanup) Please feel free to merge the PR when you do! I don't think I have access to do so. |
spokanemac
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
LGTM as well. I'll wait for @lukeheath to remove secrets and merge.
|
Out of curiosity, @getvictor , what happens to any hosts in a team that is deleted? Are they just assigned to no team or the default platform team (macOS, iOS, iPadOS)? |
|
Removed secret. |
They should go to No team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this team anymore: https://fleetdm.slack.com/archives/C071NNMSP2R/p1726610028111679?thread_ts=1726232846.113079&cid=C071NNMSP2R
Still TODO: