Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Fixes for no-team.yml GitOps (#22210) #22218

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

lucasmrod
Copy link
Member

Cherry pick for #22185

  • Manual QA for all new/changed functionality

#22185

- [X] Manual QA for all new/changed functionality
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmrod
Copy link
Member Author

Merging as the failing test is a flaky test.

@lucasmrod lucasmrod merged commit 56a4bd3 into minor-fleet-v4.57.0 Sep 18, 2024
14 of 16 checks passed
@lucasmrod lucasmrod deleted the cherry-pick-22210 branch September 18, 2024 18:04
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@a3232b2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/fleetctl/gitops.go 77.77% 1 Missing and 1 partial ⚠️
pkg/spec/gitops.go 66.66% 1 Missing and 1 partial ⚠️
server/service/client.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22218   +/-   ##
======================================================
  Coverage                       ?   65.22%           
======================================================
  Files                          ?     1493           
  Lines                          ?   116990           
  Branches                       ?     3462           
======================================================
  Hits                           ?    76310           
  Misses                         ?    33561           
  Partials                       ?     7119           
Flag Coverage Δ
backend 66.50% <68.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants