Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for no-team.yml GitOps #22210

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fixes for no-team.yml GitOps #22210

merged 2 commits into from
Sep 18, 2024

Conversation

lucasmrod
Copy link
Member

#22185

  • Manual QA for all new/changed functionality

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but TestGitOpsABM/using_an_undefined_team_errors is failing.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (1f1bc9c) to head (d6d2a3a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleetctl/gitops.go 77.77% 1 Missing and 1 partial ⚠️
pkg/spec/gitops.go 66.66% 1 Missing and 1 partial ⚠️
server/service/client.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22210      +/-   ##
==========================================
- Coverage   65.22%   65.21%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      117089   117097       +8     
  Branches     3506     3506              
==========================================
+ Hits        76366    76369       +3     
+ Misses      33613    33610       -3     
- Partials     7110     7118       +8     
Flag Coverage Δ
backend 66.50% <68.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasmrod lucasmrod merged commit 90959db into main Sep 18, 2024
25 of 26 checks passed
@lucasmrod lucasmrod deleted the 22185-fixes-gitops branch September 18, 2024 17:17
lucasmrod added a commit that referenced this pull request Sep 18, 2024
#22185

- [X] Manual QA for all new/changed functionality
lucasmrod added a commit that referenced this pull request Sep 18, 2024
Cherry pick for #22185

- [X] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants