Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through uninstall error messages from backend #22208

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 18, 2024

Checklist for submitter

  • Manual QA for all new/changed functionality

See Slack from @noahtalerman for context

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (ea2a978) to head (48f4c39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...end/pages/hosts/details/cards/Software/helpers.tsx 27.77% 13 Missing ⚠️
...ages/hosts/details/cards/Software/HostSoftware.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22208      +/-   ##
==========================================
- Coverage   65.20%   65.19%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      117089   117104      +15     
  Branches     3470     3477       +7     
==========================================
+ Hits        76344    76347       +3     
- Misses      33625    33637      +12     
  Partials     7120     7120              
Flag Coverage Δ
frontend 52.14% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Note: This helpers.ts file will likely need some cleanup the more we build it out. For now, this is great just to add to it as is

@iansltx iansltx merged commit f7fab00 into main Sep 18, 2024
14 checks passed
@iansltx iansltx deleted the uninstall-errors-passthrough branch September 18, 2024 16:22
iansltx added a commit that referenced this pull request Sep 18, 2024
iansltx added a commit that referenced this pull request Sep 18, 2024
Cherry-pick of #22208

Command run:

```
git checkout minor-fleet-v4.57.0 && git checkout -b uninstall-errors-passthrough-cherry-pick && git cherry-pick f7fab00 && git push -u origin uninstall-errors-passthrough-cherry-pick
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants