Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for adding fleet maintained apps #22204

Merged
merged 20 commits into from
Sep 20, 2024

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Sep 18, 2024

relates to #21775

NOTE: there still needs to be integrated with the API when this work is done.

Adds the UI for adding Fleet maintained applications. This includes:

the view to see all the fleet maintained apps

image

The fleet maintained app details Page:

image

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 changed the base branch from main to feat-fleet-app-library September 18, 2024 14:55
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 38.63636% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-fleet-app-library@4d54dc8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
frontend/services/entities/software.ts 0.00% 14 Missing ⚠️
...er/DataTable/SoftwareNameCell/SoftwareNameCell.tsx 0.00% 1 Missing ⚠️
...ontend/pages/SoftwarePage/components/icons/Box.tsx 50.00% 1 Missing ⚠️
...tend/pages/SoftwarePage/components/icons/Brave.tsx 50.00% 1 Missing ⚠️
...pages/SoftwarePage/components/icons/Cloudflare.tsx 50.00% 1 Missing ⚠️
...end/pages/SoftwarePage/components/icons/Docker.tsx 50.00% 1 Missing ⚠️
...ntend/pages/SoftwarePage/components/icons/Edge.tsx 50.00% 1 Missing ⚠️
...tend/pages/SoftwarePage/components/icons/Figma.tsx 50.00% 1 Missing ⚠️
...end/pages/SoftwarePage/components/icons/Notion.tsx 50.00% 1 Missing ⚠️
...pages/SoftwarePage/components/icons/TeamViewer.tsx 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                    Coverage Diff                    @@
##             feat-fleet-app-library   #22204   +/-   ##
=========================================================
  Coverage                          ?   65.19%           
=========================================================
  Files                             ?     1505           
  Lines                             ?   117148           
  Branches                          ?     3567           
=========================================================
  Hits                              ?    76376           
  Misses                            ?    33656           
  Partials                          ?     7116           
Flag Coverage Δ
frontend 52.08% <38.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghernandez345 ghernandez345 marked this pull request as ready for review September 18, 2024 16:02
@ghernandez345 ghernandez345 requested a review from a team as a code owner September 18, 2024 16:02
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghernandez345 ghernandez345 merged commit 314219a into feat-fleet-app-library Sep 20, 2024
11 checks passed
@ghernandez345 ghernandez345 deleted the feat-ui-fleet-managed-apps branch September 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants