Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure edited scripts provided from the client with newline switches and no other changes get converted to "\n" (#22196) #22199

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Ensure edited scripts provided from the client with newline switches and no other changes get converted to "\n" (#22196) #22199

merged 1 commit into from
Sep 18, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 18, 2024

Checklist for submitter

  • Manual QA for all new/changed functionality

@iansltx iansltx requested a review from a team as a code owner September 18, 2024 13:43
@iansltx iansltx merged commit ea2a978 into main Sep 18, 2024
15 checks passed
@iansltx iansltx deleted the bugfix-22196 branch September 18, 2024 14:46
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (1f1bc9c) to head (962e85c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22199      +/-   ##
==========================================
- Coverage   65.22%   65.21%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      117089   117089              
  Branches     3506     3506              
==========================================
- Hits        76366    76364       -2     
+ Misses      33613    33609       -4     
- Partials     7110     7116       +6
Flag Coverage Δ
backend 66.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iansltx added a commit that referenced this pull request Sep 18, 2024
@iansltx
Ensure edited scripts provided from the client with newline switches …
830b44b 
…and no other changes get converted to "\n" (#22196) (#22199)

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
@iansltx iansltx mentioned this pull request Sep 18, 2024
Merged
iansltx added a commit that referenced this pull request Sep 18, 2024
@iansltx
Cherry-pick: Ensure edited scripts provided from the client with newl…
7d36b1b 
…ine switches and no other changes get converted to "\n" (#22196) (#22202)

Merged to `main` in #22199.

```
git checkout minor-fleet-v4.57.0
git checkout -b 22196-cherry-pick
git cherry-pick ea2a978
git push -u origin 22196-cherry-pick
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmrod lucasmrod lucasmrod approved these changes

Assignees

@lucasmrod lucasmrod

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iansltx @lucasmrod