Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For R.C. - Use previous package filename for activity if installer edit doesn't change the package #22188

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

RachelElysia
Copy link
Member

Note

This PR is already merged in main, see #22177 This is against the release branch so it can be included in 4.57.0

1140  git fetch fleetdm 
 1141  git checkout fleetdm/minor-fleet-v4.57.0
 1142  git log main
 1143  git cherry-pick 518a4a1f98db33ad62fccf35231b5191e11e8d0a
 1144  git checkout -b 20404-be-fix-rc
 1145  git push -u fleetdm 20404-be-fix-rc

…change the package (#22177)

Also adds a line in the makefile help for generate-doc, as it took me
way too long to find that command this time.

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@3df9ebd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22188   +/-   ##
======================================================
  Coverage                       ?   65.21%           
======================================================
  Files                          ?     1493           
  Lines                          ?   116924           
  Branches                       ?     3462           
======================================================
  Hits                           ?    76252           
  Misses                         ?    33560           
  Partials                       ?     7112           
Flag Coverage Δ
backend 66.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 3a7e899 into minor-fleet-v4.57.0 Sep 18, 2024
20 checks passed
@RachelElysia RachelElysia deleted the 20404-be-fix-rc branch September 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants