For R.C. - 20404: Edit packages feature #22169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue Cerra #20404 ## Description - Add frontend/API backend for editing software packages. GitOps will be a separate PR. ## More - Please see subtasks for change lists - #21611 - #21613 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Manual QA for all new/changed functionality Automated tests will follow in another PR. --------- Co-authored-by: Ian Littman <[email protected]> Co-authored-by: Luke Heath <[email protected]> Co-authored-by: Jacob Shandling <[email protected]> Co-authored-by: Victor Lyuboslavsky <[email protected]>
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## minor-fleet-v4.57.0 #22169 +/- ##
======================================================
Coverage ? 65.19%
======================================================
Files ? 1494
Lines ? 117014
Branches ? 3553
======================================================
Hits ? 76283
Misses ? 33619
Partials ? 7112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
previously approved these changes
Sep 17, 2024
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
requested changes
Sep 17, 2024
Co-authored-by: Rachael Shaw <[email protected]>
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
previously approved these changes
Sep 17, 2024
jacobshandling
previously approved these changes
Sep 17, 2024
RachelElysia
dismissed stale reviews from jacobshandling and rachaelshaw
via
27034e4
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
rachaelshaw
approved these changes
Sep 17, 2024
iansltx
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This cherry-pick is only of 21812, unreleased bugs found in QA process will be cherry picked separately for trackability on zenhub)
Note
This PR is already merged in
main, see #21812 This is against the release branch so it can be included in 4.57.0