Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to policy software installations (#22148) #22166

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Sep 17, 2024

Cherry pick for #22104.

PR for the three fixes described in #22104.

- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@e96d5cc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/client.go 60.00% 4 Missing ⚠️
server/service/software_installers.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22166   +/-   ##
======================================================
  Coverage                       ?   65.36%           
======================================================
  Files                          ?     1493           
  Lines                          ?   116641           
  Branches                       ?     3476           
======================================================
  Hits                           ?    76237           
  Misses                         ?    33289           
  Partials                       ?     7115           
Flag Coverage Δ
backend 66.66% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasmrod lucasmrod merged commit ca45468 into minor-fleet-v4.57.0 Sep 17, 2024
22 checks passed
@lucasmrod lucasmrod deleted the fixes-policy-installers-minor-4.57.0-cherry-pick branch September 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants