Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CA certificates with extendedKeyUsage attributes. #22160

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Sep 17, 2024

for #22158

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@roperzh roperzh marked this pull request as ready for review September 17, 2024 15:29
@roperzh roperzh requested a review from a team as a code owner September 17, 2024 15:29
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.21%. Comparing base (d56a816) to head (c461014).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22160      +/-   ##
==========================================
- Coverage   65.34%   65.21%   -0.13%     
==========================================
  Files        1493     1493              
  Lines      116709   117011     +302     
  Branches     3508     3508              
==========================================
+ Hits        76258    76307      +49     
- Misses      33338    33598     +260     
+ Partials     7113     7106       -7     
Flag Coverage Δ
backend 66.51% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roperzh roperzh merged commit 2bfbf2f into main Sep 17, 2024
21 checks passed
@roperzh roperzh deleted the 22158-scep-validation branch September 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants