Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltip for mac minimum target OS version label #22157

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

ghernandez345
Copy link
Contributor

relates to #21976

before:

image

after:
image

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (78ad174) to head (5b3c138).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22157   +/-   ##
=======================================
  Coverage   65.34%   65.35%           
=======================================
  Files        1493     1495    +2     
  Lines      116651   116703   +52     
  Branches     3452     3526   +74     
=======================================
+ Hits        76229    76266   +37     
- Misses      33316    33330   +14     
- Partials     7106     7107    +1     
Flag Coverage Δ
frontend 52.14% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roperzh
roperzh previously approved these changes Sep 17, 2024
Copy link
Member

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, we should stop using DEP, but that's the copy in the figma.

Copy link
Member

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a minor change.

@gillespi314 gillespi314 merged commit 36ea5cc into main Sep 18, 2024
14 checks passed
@gillespi314 gillespi314 deleted the fix-ui-change-mac-min-version-tooltip branch September 18, 2024 20:53
gillespi314 added a commit that referenced this pull request Sep 18, 2024
gillespi314 added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants