Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saml-auth-proxy saves alb logs and outputs sec grp. #22030

Merged
merged 1 commit into from
Sep 12, 2024
Merged

saml-auth-proxy saves alb logs and outputs sec grp. #22030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions terraform/addons/saml-auth-proxy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ No requirements.

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_alb_access_logs"></a> [alb\_access\_logs](#input\_alb\_access\_logs) | n/a | `map(string)` | `{}` | no |
| <a name="input_alb_target_group_arn"></a> [alb\_target\_group\_arn](#input\_alb\_target\_group\_arn) | n/a | `string` | n/a | yes |
| <a name="input_base_url"></a> [base\_url](#input\_base\_url) | n/a | `string` | n/a | yes |
| <a name="input_cookie_max_age"></a> [cookie\_max\_age](#input\_cookie\_max\_age) | n/a | `string` | `"1h"` | no |
Expand All @@ -53,6 +54,7 @@ No requirements.
|------|-------------|
| <a name="output_fleet_extra_execution_policies"></a> [fleet\_extra\_execution\_policies](#output\_fleet\_extra\_execution\_policies) | n/a |
| <a name="output_lb"></a> [lb](#output\_lb) | n/a |
| <a name="output_lb_security_group"></a> [lb\_security\_group](#output\_lb\_security\_group) | n/a |
| <a name="output_lb_target_group_arn"></a> [lb\_target\_group\_arn](#output\_lb\_target\_group\_arn) | Keep for legacy support for now |
| <a name="output_name"></a> [name](#output\_name) | n/a |
| <a name="output_secretsmanager_secret_id"></a> [secretsmanager\_secret\_id](#output\_secretsmanager\_secret\_id) | n/a |
2 changes: 1 addition & 1 deletion terraform/addons/saml-auth-proxy/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module "saml_auth_proxy_alb" {
subnets = var.subnets
security_groups = [aws_security_group.saml_auth_proxy_alb.id]
# FIXME: Get this working eventually.
# access_logs = var.alb_config.access_logs
access_logs = var.alb_access_logs

internal = true
target_groups = [
Expand Down
4 changes: 4 additions & 0 deletions terraform/addons/saml-auth-proxy/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ output "lb" {
value = module.saml_auth_proxy_alb
}

output "lb_security_group" {
value = aws_security_group.saml_auth_proxy_alb.id
}

output "secretsmanager_secret_id" {
value = aws_secretsmanager_secret.saml_auth_proxy_cert.id
}
5 changes: 5 additions & 0 deletions terraform/addons/saml-auth-proxy/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ variable "alb_target_group_arn" {
type = string
}

variable "alb_access_logs" {
type = map(string)
default = {}
}

# variable "public_alb_security_group_id" {
# type = string
# }
Expand Down
Loading