Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20404: Edit packages feature #21812

Merged
merged 58 commits into from
Sep 17, 2024
Merged

20404: Edit packages feature #21812

merged 58 commits into from
Sep 17, 2024

Commits on Sep 14, 2024

  1. Start of work

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d7cbe2e View commit details
    Browse the repository at this point in the history

  2. Updates to FileUploader to include FileDetails if fileDetails is prov… 

    …ided
    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1aa091a View commit details
    Browse the repository at this point in the history

  3. Add global activity for edit software plus tests for add, edit, delet… 

    …e software
    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4add471 View commit details
    Browse the repository at this point in the history

  4. Work towards API call

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    5b236f6 View commit details
    Browse the repository at this point in the history

  5. More minor changes

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b7296b2 View commit details
    Browse the repository at this point in the history

  6. Proof of concept of save modal, need work on uploader refactor

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    759d607 View commit details
    Browse the repository at this point in the history

  7. Updates to FileUploader to include FileDetails if fileDetails is prov… 

    …ided
    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    bbac147 View commit details
    Browse the repository at this point in the history

  8. Proof of concept of save modal, need work on uploader refactor

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    2a79f6d View commit details
    Browse the repository at this point in the history

  9. Updates to have FileDetails separate component, move confirm save cha… 

    …nges logic into edit software modal, reinstate CSS, update comments
    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    05ce2f7 View commit details
    Browse the repository at this point in the history

  10. Fix merge problems

    @RachelElysia @iansltx
    RachelElysia authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    902c933 View commit details
    Browse the repository at this point in the history

  11. Start backend build for Edit Software 

    Lots left todo.

Might need:

svc.ds.GetHostLastInstallData(ctx, host.ID, installer.InstallerID)
preProcessUninstallScript(payload) + GetUninstallScript()
datastore mock
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    e4b9039 View commit details
    Browse the repository at this point in the history

  12. Fix types

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9d7b6b0 View commit details
    Browse the repository at this point in the history

  13. Add audit logs docs, start building uninstall script editing

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    48addad View commit details
    Browse the repository at this point in the history

  14. Finish uninstall script handling, start building software package upl… 

    …oad handling
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b62f536 View commit details
    Browse the repository at this point in the history

  15. Cleanup on activities, software installer handling

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    a9824fd View commit details
    Browse the repository at this point in the history

  16. Finish installer validation, add installer file persistence

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    762be90 View commit details
    Browse the repository at this point in the history

  17. Wire up cancellation of pending installs

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    91334c6 View commit details
    Browse the repository at this point in the history

  18. Typo fix

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8111717 View commit details
    Browse the repository at this point in the history

  19. Fix request type, move endpoint under correct heading

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f5b288d View commit details
    Browse the repository at this point in the history

  20. Switch endpoint to /:id/package

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7577ccd View commit details
    Browse the repository at this point in the history

  21. Switch response to installer rather than entire title

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    115acda View commit details
    Browse the repository at this point in the history

  22. Hydrate updated installer statuses

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    28f9269 View commit details
    Browse the repository at this point in the history

  23. Implement install count clearing 

    Setting removed = TRUE is semantically correct here, so we can use the existing column
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7438e77 View commit details
    Browse the repository at this point in the history

  24. Implement installer update on save

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d1a4648 View commit details
    Browse the repository at this point in the history

  25. Remove no-longer-relevant TODOs

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3a4b190 View commit details
    Browse the repository at this point in the history

  26. Fix lint issues

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    914f3ed View commit details
    Browse the repository at this point in the history

  27. Fix API docs generation

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c7433e8 View commit details
    Browse the repository at this point in the history

  28. Require team ID

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    93d44ef View commit details
    Browse the repository at this point in the history

  29. Map uninstall script on request

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    457608a View commit details
    Browse the repository at this point in the history

  30. Use installer metadata from DB where we can rather than file-based meta 

    This is one step toward dropping the requirement to pull the existing installer to properly diff to the new one
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8fa3455 View commit details
    Browse the repository at this point in the history

  31. Hook up UI to API endpoints

    @lukeheath @iansltx
    lukeheath authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    da21623 View commit details
    Browse the repository at this point in the history

  32. Fix cancel pending installs query

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9a551b7 View commit details
    Browse the repository at this point in the history

  33. Use full payload for software edits 

    This still doesn't work correctly for the installer itself, but metadata looks fine

TODO:

1. Fix change detection (save button) for install script
2. Fix installer re-upload
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    0810842 View commit details
    Browse the repository at this point in the history

  34. Switch to from-DB existing installer metadata for Extension, clean up… 

    … naming
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7c218c2 View commit details
    Browse the repository at this point in the history

  35. Use package IDs list from database when needed for uninstall script c… 

    …alc/diff

This allows us to not have to pull the existing installer file from file storage to perform edits.
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4c800e0 View commit details
    Browse the repository at this point in the history

  36. Add cancellation of pending uninstalls

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    43a2e10 View commit details
    Browse the repository at this point in the history

  37. Add godoc for new data store methods, add documentation on which fiel… 

    …ds need to be set for data store updates in payload
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    42da057 View commit details
    Browse the repository at this point in the history

  38. Clarify software title ID parameter, pull into software installer upd… 

    …ate payload
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b1f773f View commit details
    Browse the repository at this point in the history

  39. Wire up install script changes correctly

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8e65a9e View commit details
    Browse the repository at this point in the history

  40. Fix file upload for software edit, touch uploaded_at when a new packa… 

    …ge is uploaded
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    685f90e View commit details
    Browse the repository at this point in the history

  41. Lint fix

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    81aff9a View commit details
    Browse the repository at this point in the history

  42. Rename AddPackage(Form|AdvancedOptions)

    @iansltx
    Jacob Shandling authored and iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f1a0df9 View commit details
    Browse the repository at this point in the history

  43. Delete stray/duplicate route

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1b35fbf View commit details
    Browse the repository at this point in the history

  44. Remove redundant source check (extension check is tighter)

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    1d0a8c6 View commit details
    Browse the repository at this point in the history

  45. Typo fix

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    fa7621d View commit details
    Browse the repository at this point in the history

  46. Remove uninstall script commented validation (excluded in IPackageFor… 

    …mValidatorKey anyway)
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    de4bbff View commit details
    Browse the repository at this point in the history

  47. Reorder imports

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c76a5f7 View commit details
    Browse the repository at this point in the history

  48. Bail if we get nil pointers where we don't expect them

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8f4a305 View commit details
    Browse the repository at this point in the history

  49. Switch to map[string]bool for dirty check

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    a2365e7 View commit details
    Browse the repository at this point in the history

  50. Merge installer update side effects into a single data store method, … 

    …wrap all in a transaction
    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    154036b View commit details
    Browse the repository at this point in the history

  51. Finish frontend work for Edit Software

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9a653ad View commit details
    Browse the repository at this point in the history

  52. add changes file

    @iansltx
    iansltx committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ee90a01 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Fix dirty check for simpler update 

    Co-authored-by: Victor Lyuboslavsky <[email protected]>
    @iansltx @getvictor
    iansltx and getvictor committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e90352b View commit details
    Browse the repository at this point in the history

  2. We don't need to skip for a blank script here

    @iansltx
    iansltx committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fdd6f2d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 20404-edit-software-fe

    @iansltx
    iansltx committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    78d2b83 View commit details
    Browse the repository at this point in the history

  4. Revert "We don't need to skip for a blank script here" 

    This reverts commit fdd6f2d.

Post install script ID is by default nil, which is what we want for a blank
script, so the post-install script check was correct.
    @iansltx
    iansltx committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f14e9ee View commit details
    Browse the repository at this point in the history

  5. Ensure multipart array values aren't stacked on top of each other 

    Because of how pointers work, the previous implementation wasn't shadowing values, but this is clearer/safer
    @iansltx
    iansltx committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bd7097a View commit details
    Browse the repository at this point in the history

  6. Handle CodeQL issue

    @iansltx
    iansltx committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f4d36cc View commit details
    Browse the repository at this point in the history