feat(ui): Settings > Indent size

[kobenguyent]

resolves #31

[netlify]

✅ Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name	Link
🔨 Latest commit	46f9025
🔍 Latest deploy log	https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66e2e3486b0e0f0008067e07
😎 Deploy Preview	https://deploy-preview-240--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[flawiddsouza]

Always move each import to new line. Like how other imports are.

[flawiddsouza]

This as well:

[flawiddsouza]

Let's change the indent size to a select instead of input type number. Provide two options 2 and 4. Let 4 be shown by default if nothing can be retrieved from local storage. We'll add more options if people request it.

Also I saw this:
parseInt(number, 10)

Let the parseInt happen before it reaches the helper method. Add type number to the function param in typescript. Also remove the replacer from parameters of the helper function as it's never used anywhere. It was passed only because it was necessary for json.stringify.

[flawiddsouza]

selected does nothing when you have a v-model on select, you can remove it.

Instead of any, it's best to define the type when you know it and it's simple enough:

export function getEditorConfig(): {
    indentSize: number
} {
    return {
        indentSize: parseInt(localStorage.getItem(constants.LOCAL_STORAGE_KEY.INDENT_SIZE) || constants.EDITOR_CONFIG.indent_size.toString(), 10)
    }
}

export function jsonStringify(data: any, space: number = getEditorConfig().indentSize): any {
    return JSON.stringify(data, null, space)
}

[flawiddsouza]

That indent looks weird. I don't know what's wrong with eslint. Let's do one thing, create a new type EditorConfig in packages/ui/src/global.d.ts and use it here.

Also you missed this type I mentioned above:
export function jsonStringify(data: any, space: number = getEditorConfig().indentSize): any {
return JSON.stringify(data, null, space)
}