Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Import > auto detect imported file #239

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

kobenguyent
Copy link
Collaborator

resolves #237

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 108e4cc
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66e3caa64d43f500076a0207
😎 Deploy Preview https://deploy-preview-239--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

image
Feature looks very good. But this accidentally removes the url import functionality. Can you restore the dropdown? Let the dropdown be there. Let the select autofill with the detected import (which should happen automatically since it's bound to the same importFrom property used by the auto detector).

@kobenguyent
Copy link
Collaborator Author

image

Feature looks very good. But this accidentally removes the url import functionality. Can you restore the dropdown? Let the dropdown be there. Let the select autofill with the detected import (which should happen automatically since it's bound to the same importFrom property used by the auto detector).

Oh, I haven't noticed this. Reverting the dropdownlist.

@flawiddsouza
Copy link
Owner

image
One issue. This stays as the first option (Restfox) in select because file detection happens while importing postman collection. importFrom needs to update on drop / file selection

@flawiddsouza
Copy link
Owner

image
Remove this logic, as it's overriding user selection. As file type is already detected when file is selected.

I'm unable to import a postman zip export.

@flawiddsouza
Copy link
Owner

Can you restore the newlines that were here before? image

@flawiddsouza flawiddsouza merged commit 5aae3ac into main Sep 13, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-auto-detect-collection-type branch September 13, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-detect app collection and import it accordingly
2 participants