Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Navbar > Export as Insomnia collection #226

Merged
merged 3 commits into from
Aug 16, 2024
Merged

feat(ui): Navbar > Export as Insomnia collection #226

merged 3 commits into from
Aug 16, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Aug 16, 2024 •
edited
Loading

resolves #224

Screenshot 2024-08-16 at 16 39 27

@kobenguyent kobenguyent linked an issue Aug 16, 2024 that may be closed by this pull request
Export collection to Insomnia collection #224
Closed
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit da7505d
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66bf6f3bf5fa8800089b10ff
😎 Deploy Preview https://deploy-preview-226--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Wow, that was really fast!

This function name needs to be less generic and more specific:
image

@flawiddsouza
Copy link
Owner

Spelling: converInsomniatAuth -> convertInsomniaAuth

Maybe naming it convertRestfoxAuthToInsomniaAuth would be better.

@kobenguyent
Copy link
Collaborator Author

Spelling: converInsomniatAuth -> convertInsomniaAuth

Maybe naming it convertRestfoxAuthToInsomniaAuth would be better.

sure, let's take it.

@flawiddsouza flawiddsouza merged commit 9683d03 into main Aug 16, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the 224-export-collection-to-insomnia-collection branch August 16, 2024 16:07
@flawiddsouza
Copy link
Owner

@kobenguyent The insomnia export fails / errors out if you create a new request (add only url) and try to export. Can you check?

@flawiddsouza
Copy link
Owner

@kobenguyent I've fixed this. No worries.

@kobenguyent
Copy link
Collaborator Author

Oh cool! Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flawiddsouza flawiddsouza flawiddsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export collection to Insomnia collection
2 participants
@kobenguyent @flawiddsouza