Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): support window status saving #176

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mofazhe
Copy link
Contributor

@mofazhe mofazhe commented Jul 5, 2024

feat: After the window is turned off, it can save the original size. After opening the window again, it can return to the size saved before.
Use this package: https://github.com/mawie81/electron-window-state

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 056f25c
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/668bb014bbb99f0008339ceb
😎 Deploy Preview https://deploy-preview-176--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Seems like a good feature to have but I'm seeing two bugs raised related to this package.

mawie81/electron-window-state#27
whyboris/Video-Hub-App#572

It was also last updated in 2018, so that's 6 years ago.

image

A bit worried. I don't want to introduce these bugs.

@mofazhe
Copy link
Contributor Author

mofazhe commented Jul 6, 2024

OK, I will look into adding this library code directly to Restfox and solve the multi-monitor adaptation problem at the same time.

@mofazhe
Copy link
Contributor Author

mofazhe commented Jul 7, 2024

I improved the multi-monitor adaptation. I only tested on Windows 10 and it worked fine. Let me know if you run into any problems with other systems.


I can't reproduce the issue of whyboris/Video-Hub-App#572, it may not be related to this electron-window-state library.
I tried switching between these options repeatedly, and the window was displayed correctly on the corresponding monitor.
image

@flawiddsouza flawiddsouza merged commit 2f6fb9c into flawiddsouza:main Jul 8, 2024
4 checks passed
@mofazhe mofazhe deleted the feat/win-state-keeper branch July 8, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants