Publish package #50
Merged
Publish package #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to read the version from the current git tag instead of having it hardcoded in some file.
We use setuptools_scm now which includes everything under version control.
This reverts commit 66bcd9f.
It doesn't look like it's used anywhere and breaks publishing to PIPY.
It's not needed anymore since we only listen to `workflow_dispatch` events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for publishing is that the
CHANGELOG.mdfile is the source of truth for the version number. To make a new release, you add a new version entry in the changelog and push and merge this change. A github action will detect a new version number and build and publish a new package. The action also adds a git tag and github release reflecting the new version.However, there is some logic needed for this and we want a way to publish until this is in a good shape. This PR adds a simple workflow that listens to PRs being merged to main whose head branch is
release/<version-number>. It uses theversion-numberpart to version the package.