Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull request to test CI #33

Merged
merged 9 commits into from
Oct 5, 2023
Merged

pull request to test CI #33

merged 9 commits into from
Oct 5, 2023

Conversation

hagrid67
Copy link
Contributor

No description provided.

@hagrid67 hagrid67 linked an issue Sep 22, 2023 that may be closed by this pull request
upgrade to python 3.10 and new pytest #32
Closed
1 task
manuschn
manuschn requested changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@manuschn manuschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes! great that the tests are successful again :)

I left a few comments, nothing crucial though.

Before merging, I would include testing with python 3.10 in the existing GitHub actions since you already added them to tox: to run tests also for python 3.10, change python-version: [ "3.7", "3.8", "3.9" ] in both checks.yml and main.yml to python-version: [ "3.7", "3.8", "3.9", "3.10" ].

tests/test_flatland_envs_rail_env_shortest_paths.py Outdated Show resolved Hide resolved
flatland/core/transition_map.py Show resolved Hide resolved
tests/test_flatland_envs_rail_env_shortest_paths.py Outdated Show resolved Hide resolved
@hagrid67
Copy link
Contributor Author

hagrid67 commented Sep 29, 2023 •
edited
Loading

I wanted to change the yaml files but I believe I need workflow permission on github - the commits fail. (Or at least they did when I tried a week ago.)
Maybe once that is granted, I need to create a new "personal access token".

(refusing to allow a Personal Access Token to create or update workflow .github/workflows/checks.yml without workflow scope)

@fnberta fnberta requested a review from a team as a code owner October 5, 2023 20:43
@fnberta fnberta enabled auto-merge (squash) October 5, 2023 21:03
manuschn
manuschn approved these changes Oct 5, 2023
View reviewed changes
flatland/core/transition_map.py
self.grid[cell_id[0]][cell_id[1]] = self.transitions.set_transition(
self.grid[cell_id[0:2]],
cell_id[2],
nDir, # cell_id[2],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nDir, # cell_id[2],
nDir,

@fnberta fnberta merged commit b6dd35f into main Oct 5, 2023
7 checks passed
@fnberta fnberta deleted the iss-032-python310 branch October 5, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnberta fnberta fnberta approved these changes

@manuschn manuschn manuschn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to python 3.10 and new pytest
3 participants
@hagrid67 @fnberta @manuschn