Add a shell-wrapper file #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blt-r
force-pushed
the
shell_wrapper
branch
2 times, most recently
from
85f8ee3
to
cec48c4
Compare
|
That's great!! Would help a lot to Neovim too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In helix, there's no integrated terminal in the editor. So it isn't possible to have a shell session in the environment set up by the wrapper. In this PR, I added a
shell-wrapper(maybe another name would be better) executable into/app/binthat just sets up the environment and launches bash. Users will be able toflatpak run --command=shell-wrapper com.helix_editor.Helix, and have the packages isolated, so that they can, for example,pip installpackages.To do that, I separated the logic of setting up the environment into
wrapper.shwhich is installed into/app/lib/ide-flatpak-wrapper/wrapper.shand is sourced fromeditor.shandshell_wrapper.sh. I also added the-Dshell_wrapper_nameoption to set the name of theshell_wrapper.shexecutable (defaults toshell-wrapper).