Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cargo fmt and clippy issues #11

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

dongsupark
Copy link
Member

Address issues of cargo fmt as well as cargo clippy.

In CI, run also cargo fmt and cargo test.
Use actions-rs/cargo Github Actions.

@dongsupark dongsupark requested a review from a team October 19, 2023 15:57
@dongsupark
Copy link
Member Author

(ignore the unit test failures, as it will be fixed in the other PR.)

.rustfmt.toml Outdated Show resolved Hide resolved
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use a custom .rustfmt.toml but stick to the existing (default rustfmt) formatting

Run also `cargo fmt` and `cargo test`.
Use actions-rs/cargo Github Actions.
@dongsupark
Copy link
Member Author

Done with removing a local rustfmt.toml.

@dongsupark dongsupark merged commit b1c8362 into flatcar-master Nov 9, 2023
1 check failed
@dongsupark dongsupark deleted the dongsu/fmt-clippy branch November 9, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants