Add the VNI to the error message in Windows #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +103,7 @@ func (nw *network) handleSubnetEvents(batch []lease.Event) { | |||
| } | |||
|
|
|||
| if vxlanAttrs.VNI < 4096 { | |||
| log.Error("VNI is required to greater than or equal to 4096 on Windows.") | |||
| log.Errorf("VNI is %d but it is required to greater than or equal to 4096 on Windows.", vxlanAttrs.VNI) | |||
There was a problem hiding this comment.
nitpicking: it is required to be greater
There was a problem hiding this comment.
good point! I copied/pasted the error
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
flannelWin
branch
from
47695a9
to
a3631b8
Compare
thomasferrandiz
approved these changes
Dec 18, 2023
rbrtbnfgl
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a log that complains about the VNI not being 4096 but it does not specify what is the value. This PR adds that information to the log line
Todos
Release Note