Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedigree map combined changes #4228

Closed
wants to merge 7 commits into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Feb 22, 2022

This PR takes the elements applicable to the Pedigree map module from the following PR's so as to provide a consolidated collection of changes. #4202, #4203, #4208, #4211

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #4228 (5d4e8b0) into main (415d36f) will decrease coverage by 0.85%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4228      +/-   ##
============================================
- Coverage     32.63%   31.78%   -0.86%     
- Complexity    11047    11072      +25     
============================================
  Files          1093     1090       -3     
  Lines         40449    39047    -1402     
============================================
- Hits          13202    12411     -791     
+ Misses        27247    26636     -611     
Impacted Files Coverage Δ
app/Module/PedigreeMapModule.php 0.00% <0.00%> (ø)
app/Validator.php 58.62% <0.00%> (-37.27%) ⬇️
app/Elements/XrefMedia.php 36.84% <0.00%> (-17.01%) ⬇️
app/Census/CensusColumnRelationToHead.php 60.00% <0.00%> (-15.00%) ⬇️
app/Http/RequestHandlers/AccountEdit.php 81.81% <0.00%> (-11.74%) ⬇️
app/Elements/EventTypeCitedFrom.php 90.90% <0.00%> (-9.10%) ⬇️
app/Services/TreeService.php 14.28% <0.00%> (-8.90%) ⬇️
app/Elements/AbstractEventElement.php 76.92% <0.00%> (-6.42%) ⬇️
app/Http/RequestHandlers/UserListData.php 65.30% <0.00%> (-5.39%) ⬇️
app/Elements/XrefSource.php 88.88% <0.00%> (-4.87%) ⬇️
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415d36f...5d4e8b0. Read the comment docs.

@ddrury ddrury force-pushed the Pedigree_map_combined_changes branch 4 times, most recently from 34e2c4c to 11659da Compare February 22, 2022 14:18
@ddrury
Copy link
Contributor Author

ddrury commented Feb 22, 2022

Note:
The following lines should have been removed from chart.phtml in commit "Provide ability to switch the parent-child lines on or off " but were omitted in error and subsequently removed in commit "Add parent identifier & thumbnail image to Pedigree map sidebar".

About lines 113 - 116 in onEachFeature: function (feature, layer) {

if (feature.properties.polyline) {
  let pline = L.polyline(feature.properties.polyline.points, feature.properties.polyline.options);
   markers.addLayer(pline);
}

@ddrury ddrury force-pushed the Pedigree_map_combined_changes branch from 11659da to 7167806 Compare February 23, 2022 09:56
@ddrury ddrury force-pushed the Pedigree_map_combined_changes branch from 7167806 to c5be6dc Compare February 23, 2022 09:58
@ddrury ddrury closed this Nov 25, 2022
@ddrury ddrury deleted the Pedigree_map_combined_changes branch November 26, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants