Apply softAES asm for older CPUs from xmrig via @cppdev-123 #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks I will have a look to it soon.
|
|
Still kind of hacking on it / it doesn't actually work yet / but now its has some more wiring done (hopefully close to correct/useful or on the right track) |
|
sry for the long delay I will review this PR this week. |
|
It is quite a mess, now, since the whitespace changes and other giant leaps of code. :/ |
|
@Spudz76 I have not forget you, I am currently busy because of some health issues of myself and my kid. |
|
I am currently testing this code but somehow under linux it crashes: I am currently searching the reason |
psychocrypt
reviewed
May 18, 2019
| int32_t cpu_info[4]; | ||
| char cpustr[13] = {0}; | ||
| char brandstr[13] = {0}; |
There was a problem hiding this comment.
if I set this to 64 it solves the first issue
|
It is still crashing under linux. Need to look deeper into it. |
|
I looked in to the original Pr and @cppdev-123 mentioned that it crashes under linux |
…ed over some more stuff for WOW+RWZ
…U detection so asm_type can be matched up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(mostly) Same as #2362 minus all the off-topic hacks and whitespace change bits; probably still needs some tuneups but at least @psychocrypt might be able to read it now