[WIP] clean memoy on miner shutdown #1885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- free host and device memory on shutdown - catch exeptions and try to do a clean shurdown (free mem) - add key `q` to close the miner
HAndle signals to close the miner
psychocrypt
force-pushed
the
topic-cleanMemoryOnShutdown
branch
from
bbb5b0e
to
22a7ce9
Compare
fireice-uk
requested changes
Oct 10, 2018
| @@ -997,6 +1001,52 @@ void executor::print_report(ex_event_name ev) | |||
| printer::inst()->print_str(out.c_str()); | |||
| } | |||
|
|
|||
| void executor::shutdown() | |||
| { | |||
| // if shutdown is called the first time | |||
There was a problem hiding this comment.
You are calling this from different threads. bQuit needs to be atomic. pvThreads is not safe. Use signals instead and wait conditions instead of calls and busy waiting.
|
no conditional is not possible you can not assume that all threads are
alive if the miner crash because of an exeption.
|
psychocrypt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qto close the minersolve #1880