Added metricExportTimeoutMillis to google-cloud.md #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `metricExportTimeoutMillis: 5_000,` to the telemetryConfig. This is needed when you define `metricExportIntervalMillis` like in the example. Without it won't run due to errors.
bryanatkinson
approved these changes
Aug 26, 2024
| @@ -88,6 +88,7 @@ googleCloud({ | |||
| '@opentelemetry/instrumentation-net': { enabled: false }, | |||
| }, | |||
| metricExportIntervalMillis: 5_000, | |||
| metricExportTimeoutMillis: 5_000, | |||
There was a problem hiding this comment.
The default values for both of these fields is 300_000. I'd suggest having this example use those defaults explicitly. Using 5s intervals is useful during development, but could end up using a lot more metric quota than is needed if deployed to production.
My guess is that this example was failing because the export interval would be lower than the default timeout.
There was a problem hiding this comment.
@chees if you can make the change above, we'll get this merged in asap. Thanks!
|
Quick ping @chees if you can make the change above, we'll get this merged in asap. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
metricExportTimeoutMillis: 5_000,to the telemetryConfig. This is needed when you definemetricExportIntervalMillislike in the example. Without it won't run due to errors.